Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the ability to specify custom rules.json path #368

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Added the ability to specify custom rules.json path #368

merged 4 commits into from
Aug 1, 2024

Conversation

borisf94
Copy link

Description

In this PR I've added the --custom-rules-json-path CLI parameter to be able to specify a custom Rules.Json file location.
This is required to inject custom rules that are not part of the basic functionality included with Template Analyzer.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [V] Title of the pull request is clear and informative.
  • [V] Description of the pull request is clear and informative.
  • [V] I have added myself to the 'assignees'.
  • [V] I have added 'linked issues' if relevant.

Testing Guidelines

  • [V] Pull request includes test coverage for the included changes.

@borisf94 borisf94 requested a review from a team as a code owner July 28, 2024 16:27
@borisf94 borisf94 marked this pull request as draft July 28, 2024 16:31
@borisf94 borisf94 marked this pull request as ready for review July 28, 2024 16:32
@reynoldsa
Copy link
Contributor

Having a look today.

JohnathonMohr
JohnathonMohr requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@JohnathonMohr JohnathonMohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Just a few changes requested.

src/Analyzer.Cli/CommandLineParser.cs Outdated Show resolved Hide resolved
src/Analyzer.Cli/CommandLineParser.cs Outdated Show resolved Hide resolved
src/Analyzer.Core.UnitTests/TemplateAnalyzerTests.cs Show resolved Hide resolved
@JohnathonMohr JohnathonMohr linked an issue Jul 29, 2024 that may be closed by this pull request
Add support to allow for running custom rules #31
Closed
@reynoldsa reynoldsa merged commit f3ee0ce into Azure:main Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reynoldsa reynoldsa reynoldsa approved these changes

@JohnathonMohr JohnathonMohr JohnathonMohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to allow for running custom rules
3 participants
@borisf94 @reynoldsa @JohnathonMohr